Shahar Havivi has uploaded a new change for review. Change subject: findbugs: ignore: generate GWT class get findbugs Boolean constructor warning ......................................................................
findbugs: ignore: generate GWT class get findbugs Boolean constructor warning findbugs complain of using Boolean constructor instead of Boolean.valueOf This calss is GWT generated code findbugs reason: Dm: Method invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead (DM_BOOLEAN_CTOR) Change-Id: I006a4465cf236858c17f6be5cc27e9d811c084f9 Signed-off-by: Shahar Havivi <[email protected]> --- M frontend/webadmin/modules/gwt-common/exclude-filters.xml M frontend/webadmin/modules/webadmin/exclude-filters.xml 2 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/72/15272/1 diff --git a/frontend/webadmin/modules/gwt-common/exclude-filters.xml b/frontend/webadmin/modules/gwt-common/exclude-filters.xml index e941a9b..0ccbcc4 100644 --- a/frontend/webadmin/modules/gwt-common/exclude-filters.xml +++ b/frontend/webadmin/modules/gwt-common/exclude-filters.xml @@ -46,4 +46,30 @@ <Class name="org.ovirt.engine.ui.common.system.ApplicationFocusChange" /> <Bug code="UuF"/> </Match> + + <!-- + findbugs complain of using Boolean constructor instead of Boolean.valueOf + This calss is GWT generated code + + findbugs reason: + Dm: Method invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead (DM_BOOLEAN_CTOR) + --> + <Match> + <Class name="org.ovirt.engine.ui.common.presenter.SetDynamicTabAccessibleEvent" /> + <Method name="hashCode"/> + <Bug code="DM"/> + </Match> + + <!-- + findbugs complain of using Boolean constructor instead of Boolean.valueOf + This calss is GWT generated code + + findbugs reason: + Dm: Method invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead (DM_BOOLEAN_CTOR) + --> + <Match> + <Class name="org.ovirt.engine.ui.common.system.ApplicationFocusChangeEvent" /> + <Method name="hashCode"/> + <Bug code="DM"/> + </Match> </FindBugsFilter> diff --git a/frontend/webadmin/modules/webadmin/exclude-filters.xml b/frontend/webadmin/modules/webadmin/exclude-filters.xml index f5c9123..43110c8 100644 --- a/frontend/webadmin/modules/webadmin/exclude-filters.xml +++ b/frontend/webadmin/modules/webadmin/exclude-filters.xml @@ -225,4 +225,17 @@ <Class name="org.ovirt.engine.ui.webadmin.system.MessageReceived" /> <Bug code="UuF"/> </Match> + + <!-- + findbugs complain of using Boolean constructor instead of Boolean.valueOf + This calss is GWT generated code + + findbugs reason: + Dm: Method invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead (DM_BOOLEAN_CTOR) + --> + <Match> + <Class name="org.ovirt.engine.ui.webadmin.section.main.presenter.UpdateMainContentLayoutEvent" /> + <Method name="hashCode"/> + <Bug code="DM"/> + </Match> </FindBugsFilter> -- To view, visit http://gerrit.ovirt.org/15272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I006a4465cf236858c17f6be5cc27e9d811c084f9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
