Shahar Havivi has uploaded a new change for review. Change subject: findbugs: ignore: Suspicious reference comparison of Boolean value ......................................................................
findbugs: ignore: Suspicious reference comparison of Boolean value findbugs complains that we may compare between reference of Boolean class in this case one of the values is Boolean.True, and even if we check against its reference the comparison is good. findbugs reason: RC: Suspicious reference comparison of Boolean values (RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN) Change-Id: I6ed413bfe1def4ec7351c7224d6fd2509f5ce996 Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/restapi/jaxrs/exclude-filters.xml 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/15326/1 diff --git a/backend/manager/modules/restapi/jaxrs/exclude-filters.xml b/backend/manager/modules/restapi/jaxrs/exclude-filters.xml index 51d453f..977126e 100644 --- a/backend/manager/modules/restapi/jaxrs/exclude-filters.xml +++ b/backend/manager/modules/restapi/jaxrs/exclude-filters.xml @@ -12,4 +12,18 @@ <Method name="parseVersion"/> <Bug code="SF"/> </Match> + + <!-- + findbugs complains that we may compare between reference of Boolean class + in this case one of the values is Boolean.True, and even if we check against + its reference the comparison is good. + + findbugs reason: + RC: Suspicious reference comparison of Boolean values (RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN) + --> + <Match> + <Class name="org.ovirt.engine.api.restapi.security.auth.LoginValidator" /> + <Method name="postProcess"/> + <Bug code="SF"/> + </Match> </FindBugsFilter> -- To view, visit http://gerrit.ovirt.org/15326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6ed413bfe1def4ec7351c7224d6fd2509f5ce996 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
