Oved Ourfali has posted comments on this change. Change subject: findbugs: ignore: Suspicious reference comparison of Boolean value ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/restapi/jaxrs/exclude-filters.xml Line 22: RC: Suspicious reference comparison of Boolean values (RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN) Line 23: --> Line 24: <Match> Line 25: <Class name="org.ovirt.engine.api.restapi.security.auth.LoginValidator" /> Line 26: <Method name="postProcess"/> I think we can use "equals" in this case, instead of ignoring that test. Line 27: <Bug code="SF"/> Line 28: </Match> -- To view, visit http://gerrit.ovirt.org/15326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ed413bfe1def4ec7351c7224d6fd2509f5ce996 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
