Yedidyah Bar David has posted comments on this change.
Change subject: config: avoid to change existing configuration files
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File src/__main__.py
Line 314: )
Line 315:
Line 316: cp = ConfigParser.ConfigParser()
Line 317: #backward compatibility with existing setup
Line 318: for configfile in configs:
I am not sure what exactly you refer to, but the 'if' starting in line 320 can
be simply removed entirely some day, according to you middle step.
Line 319: cp.read(configfile)
Line 320: if cp.has_option('LogCollector', 'rhevm'):
Line 321: if not cp.has_option('LogCollector', 'engine'):
Line 322: cp.set(
--
To view, visit http://gerrit.ovirt.org/15366
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55c707424524826235f1faba52c0fafd72a27300
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Keith Robertson <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
