Alon Bar-Lev has posted comments on this change.
Change subject: config: avoid to change existing configuration files
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File src/__main__.py
Line 314: )
Line 315:
Line 316: cp = ConfigParser.ConfigParser()
Line 317: #backward compatibility with existing setup
Line 318: for configfile in configs:
python has built in support for reading multiple configurations, see above
removal.
of course it is trivial in this case, but the pattern should be consistent.
you do not change normal flow unless you are forced to because of major issue,
such as legacy is xml current is json, etc..
In this case:
cp = ConfigParser.ConfigParser()
cp.read(configs)
# legacy->current
bla bla
# continue normally
Line 319: cp.read(configfile)
Line 320: if cp.has_option('LogCollector', 'rhevm'):
Line 321: if not cp.has_option('LogCollector', 'engine'):
Line 322: cp.set(
--
To view, visit http://gerrit.ovirt.org/15366
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55c707424524826235f1faba52c0fafd72a27300
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Keith Robertson <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
