Laszlo Hornyak has posted comments on this change.
Change subject: core: Introduce scheduling package
......................................................................
Patch Set 7: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
Line 5: import javax.annotation.PostConstruct;
Line 6: import javax.ejb.DependsOn;
Line 7: import javax.ejb.Singleton;
Line 8: import javax.ejb.Startup;
Line 9:
this needs some modification after rebase
Line 10: import org.ovirt.engine.core.bll.gluster.GlusterJobsManager;
Line 11: import org.ovirt.engine.core.bll.job.ExecutionHandler;
Line 12: import org.ovirt.engine.core.bll.network.MacPoolManager;
Line 13: import org.ovirt.engine.core.bll.scheduling.MigrationHandler;
Line 46: ResourceManager.getInstance().init();
Line 47: AsyncTaskManager.getInstance().InitAsyncTaskManager();
Line 48: OvfDataUpdater.getInstance().initOvfDataUpdater();
Line 49:
Line 50: VdsLoadBalancer.getInstance().setMigrationHandler(new
MigrationHandler() {
Will there be any more implementation of the MigrationHandler interface?
Line 51:
Line 52: @Override
Line 53: public void migrateVMs(List<Pair<Guid, Guid>> list) {
Line 54: for (Pair<Guid, Guid> pair : list) {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/MigrationHandler.java
Line 6: import org.ovirt.engine.core.compat.Guid;
Line 7:
Line 8: public interface MigrationHandler {
Line 9: /**
Line 10: * this method holds a list of pairs VM id and Host id. each VM
should be migrated to the specified Host
One VM should be migrated to only a single host, isn't it? So why not just a
Map<Guid, Guid> where the key is the VM id and the value is the host id?
Line 11: * @param list
Line 12: */
Line 13: void migrateVMs(List<Pair<Guid, Guid>> list);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsSelector.java
Line 331: return result;
Line 332: }
Line 333: }
Line 334:
Line 335: return null;
I can't remember who, but someone was fighting hard against returning null (cos
it is un-OOP, he said). Just in case the guy comes back with that, for me it is
OK.
Line 336: }
Line 337:
Line 338: /**
Line 339: * Determine if specific vds already failed to run vm - to prevent
--
To view, visit http://gerrit.ovirt.org/14580
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icac8f7bc8a696455134bb90ffc17afd420e18dd3
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
