Oved Ourfali has posted comments on this change.
Change subject: findbugs: method may fail to close resource
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
consider making the code cleaner using my suggestion.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KrbConfCreator.java
Line 172: } finally {
Line 173: if (fos != null) {
Line 174: fos.close();
Line 175: }
Line 176: }
consider doing:
try (FileOutputStream fos = new FileOutputStream(krb5ConfPath)) {
fos.write(sb.toString().getBytes());
}
which is equivalent to the above, with less lines of code :-)
Line 177: }
Line 178:
Line 179: private String appendRealms(List<String> realms) throws
AuthenticationException {
Line 180: StringBuffer text = new StringBuffer(" [realms]");
--
To view, visit http://gerrit.ovirt.org/15324
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I717fa1ecf687517a0b952d8649e2a0cda7a9fd26
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
