Yair Zaslavsky has posted comments on this change.
Change subject: findbugs: method may fail to close resource
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
Line 1108: InputStream in = null;
Line 1109: OutputStream out = null;
Line 1110:
Line 1111: try {
Line 1112: in = new FileInputStream(srcFilePath);
Same as oved suggested.
Line 1113: out = new FileOutputStream(dstFilePath);
Line 1114:
Line 1115: // Transfer bytes from in to out
Line 1116: byte[] buf = new byte[1024];
--
To view, visit http://gerrit.ovirt.org/15324
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I717fa1ecf687517a0b952d8649e2a0cda7a9fd26
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
