Maor Lipchuk has submitted this change and it was merged. Change subject: core: RegisterDiskCommand - correct storage domain ......................................................................
core: RegisterDiskCommand - correct storage domain When registering new disk, the disk was saved to the db using the domain information stored on its metadata - this can cause to failure during registration or to have incorrect information stored in the engine db. The domain on which the disk was existed on isn't necessarily the new one on which the disk is now, so it shouldn't be saved with it. The following patch set the saved storage domain to the current one and is part of the complete fix which involves also setting the current id to the image metadata in vdsm. Change-Id: I568668fc1a8024ff255754287afbaa5d35b8a2ed Signed-off-by: Liron Aravot <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RegisterDiskParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDisksResource.java 3 files changed, 7 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Ar: Verified -- To view, visit http://gerrit.ovirt.org/15193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I568668fc1a8024ff255754287afbaa5d35b8a2ed Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Chris Morrissey <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
