Shubhendu Tripathi has uploaded a new change for review.

Change subject: gluster: Shown command and server name in evt log
......................................................................

gluster: Shown command and server name in evt log

Corrected the event log message shown in case a host goes
non-operational due to some issues. Earlier the message used to be shown
in the form "Gluster command [<UNKNOWN>] failed on server <UNKNOWN>."

Change-Id: I5857284b76a56f8b6b3cb8431a6997443939bb8c
Bug-Url: https://bugzilla.redhat.com/973624
Signed-off-by: Shubhendu Tripathi <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java
2 files changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/94/15794/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
index 50b91ac..7149024 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
@@ -276,8 +276,11 @@
     }
 
     private void setNonOperational(VDS server) {
+        Map<String, String> customValues = new HashMap<String, String>();
+        customValues.put(GlusterConstants.COMMAND, "gluster peer probe");
+        customValues.put(GlusterConstants.SERVER, server.getHostName());
         SetNonOperationalVdsParameters nonOpParams =
-                new SetNonOperationalVdsParameters(server.getId(), 
NonOperationalReason.GLUSTER_COMMAND_FAILED);
+                new SetNonOperationalVdsParameters(server.getId(), 
NonOperationalReason.GLUSTER_COMMAND_FAILED, customValues);
         nonOpParams.setSaveToDb(true);
         
Backend.getInstance().runInternalAction(VdcActionType.SetNonOperationalVds,
                 nonOpParams,
diff --git 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java
 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java
index 2c29aad..30ff528 100644
--- 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java
+++ 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java
@@ -35,6 +35,7 @@
     public static final String MANAGE_GLUSTER_SERVICE_ACTION_TYPE_START = 
"start";
     public static final String MANAGE_GLUSTER_SERVICE_ACTION_TYPE_STOP = 
"stop";
     public static final String MANAGE_GLUSTER_SERVICE_ACTION_TYPE_RESTART = 
"restart";
+    public static final String COMMAND = "command";
 
     public static final String HOOK_NAME = "glusterhookname";
     public static final String FAILURE_MESSAGE = "failuremessage";


-- 
To view, visit http://gerrit.ovirt.org/15794
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5857284b76a56f8b6b3cb8431a6997443939bb8c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to