Sahina Bose has posted comments on this change.
Change subject: gluster: Shown command and server name in evt log
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
Line 277:
Line 278: private void setNonOperational(VDS server) {
Line 279: Map<String, String> customValues = new HashMap<String,
String>();
Line 280: customValues.put(GlusterConstants.COMMAND, "gluster peer
probe");
Line 281: customValues.put(GlusterConstants.SERVER,
server.getHostName());
I think the message GLUSTER_COMMAND_FAILED can be changed to use vdsName
instead of Server. This way you will not need to add custom value for server in
other places - like InitVdsOnUpCommand, SetNonOperationalVdsCommand etc.
Line 282: SetNonOperationalVdsParameters nonOpParams =
Line 283: new SetNonOperationalVdsParameters(server.getId(),
NonOperationalReason.GLUSTER_COMMAND_FAILED, customValues);
Line 284: nonOpParams.setSaveToDb(true);
Line 285:
Backend.getInstance().runInternalAction(VdcActionType.SetNonOperationalVds,
--
To view, visit http://gerrit.ovirt.org/15794
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5857284b76a56f8b6b3cb8431a6997443939bb8c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
