Arik Hadas has posted comments on this change.
Change subject: engine: GMT timezone for linux vms
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
Line 1156: setAcpiEnable(vm.getAcpiEnable());
Line 1157: setGuestCurrentUserName(vm.getGuestCurrentUserName());
Line 1158: setWin2kHackEnable(vm.getWin2kHackEnable());
Line 1159: if (getOs() != null && !getOs().isLinux()) {
Line 1160: setUtcDiff(vm.getUtcDiff());
since utcDiff in VmDynamic is defined as Integer and I don't see that it gets
default value anywhere, if the vm is linux then it will remain null isn't it?
anyway I would replace it with ternary-if and set it to zero otherwise
Line 1161: }
Line 1162: setExitStatus(vm.getExitStatus());
Line 1163: setExitMessage(vm.getExitMessage());
Line 1164: setClientIp(vm.getClientIp());
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
Line 173: final Iterable<TimeZoneModel> timeZones =
TimeZoneModel.getTimeZones(getTimeZoneType());
Line 174: getModel().getTimeZone().setItems(timeZones);
Line 175:
getModel().getTimeZone().setSelectedItem(Linq.firstOrDefault(timeZones, new
Linq.TimeZonePredicate(selectedTimeZone)));
Line 176:
Line 177: if (getModel().getIsLinuxOS()) { // For linux disable
editing
I would replace this if-else with ternary statements to make it shorter. but
that's a matter of style - so just consider it
Line 178: getModel().getTimeZone().setIsChangable(false);
Line 179:
getModel().getTimeZone().setTitle(constants.timeZoneNotEditableForLinuxVms());
// $NON-NLS-1$
Line 180: } else {
Line 181: getModel().getTimeZone().setIsChangable(true);
Line 175:
getModel().getTimeZone().setSelectedItem(Linq.firstOrDefault(timeZones, new
Linq.TimeZonePredicate(selectedTimeZone)));
Line 176:
Line 177: if (getModel().getIsLinuxOS()) { // For linux disable
editing
Line 178: getModel().getTimeZone().setIsChangable(false);
Line 179:
getModel().getTimeZone().setTitle(constants.timeZoneNotEditableForLinuxVms());
// $NON-NLS-1$
no need for $NON-NLS-1$ here
Line 180: } else {
Line 181: getModel().getTimeZone().setIsChangable(true);
Line 182: getModel().getTimeZone().setTitle(""); //
$NON-NLS-1$
Line 183: }
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
Line 1891: // Gluster Hook
Line 1892: @DefaultStringValue("Please select a resolve action to continue")
Line 1893: String noResolveActionSelectedGlusterHook();
Line 1894:
Line 1895: @DefaultStringValue("Time Zone is not editable for Linux VMs")
isn't "Cannot change time zone for Linux VMs" be more appropriate message to
show to the user?
Line 1896: String timeZoneNotEditableForLinuxVms();
--
To view, visit http://gerrit.ovirt.org/15802
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If681a23a450a22685c7110a337b08f3c67609c34
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Aaron Bawcom <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Martin Beták <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
