Tomas Jelinek has posted comments on this change.
Change subject: engine: GMT timezone for linux vms
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
Line 173: final Iterable<TimeZoneModel> timeZones =
TimeZoneModel.getTimeZones(getTimeZoneType());
Line 174: getModel().getTimeZone().setItems(timeZones);
Line 175:
getModel().getTimeZone().setSelectedItem(Linq.firstOrDefault(timeZones, new
Linq.TimeZonePredicate(selectedTimeZone)));
Line 176:
getModel().getTimeZone().setIsChangable(!getModel().getIsLinuxOS());
Line 177:
getModel().getTimeZone().setTitle(getModel().getIsLinuxOS() ?
constants.timeZoneNotChangeableForLinuxVms() : "");
please consider to use setChangeProhibitionReason instead
Line 178: }
Line 179: });
Line 180: }
Line 181:
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
Line 1897: String noResolveActionSelectedGlusterHook();
Line 1898:
Line 1899: @DefaultStringValue("Please select an action to continue")
Line 1900: String noActionSelectedManageGlusterSwift();
Line 1901:
plz remove
Line 1902: @DefaultStringValue("Time Zone is not changeable for Linux VMs")
Line 1903: String timeZoneNotChangeableForLinuxVms();
--
To view, visit http://gerrit.ovirt.org/15802
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If681a23a450a22685c7110a337b08f3c67609c34
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Aaron Bawcom <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Martin Beták <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
