Shahar Havivi has posted comments on this change.
Change subject: findbugs: adding category ignore list
......................................................................
Patch Set 2: (1 inline comment)
The reason we have 2 files is:
1. project specific: bugs that we will not fix (we do not agree with findbugs
that it need to be fix)
2. categories that we decided to ignore for the same reason and categories that
we will fix in the future.
We will run Jenkins with the general profile but when user will make a project
with findbugs he will not get the general findbugs error, so he will be able
not to ignore them.
....................................................
File backend/manager/modules/bll/pom.xml
Line 249: <version>${findbugs.version}</version>
Line 250: <configuration>
Line 251: <xmlOutput>true</xmlOutput>
Line 252: <!-- Optional directory to put findbugs xdoc
xml report -->
Line 253: <excludeFilterFile>
${basedir}/exclude-filters.xml,
${basedir}/../../../../exclude-filters-general.xml</excludeFilterFile>
If I got your question correctly you want to have 2 files:
1. all projects merge to one xml and will be place in the root
2. leave the general ignore xml as is in the root
Then we will be able to modify one pom file.
That should work but the problem will be when you will build a specific project
not from the root, you will not be able to run the findbugs
Line 254:
<xmlOutputDirectory>target/site</xmlOutputDirectory>
Line 255: </configuration>
Line 256: </plugin>
Line 257: </plugins>
--
To view, visit http://gerrit.ovirt.org/15775
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfbc37df07eff4c212cc5210965cabd79a51df36
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
