Yair Zaslavsky has posted comments on this change.
Change subject: findbugs: adding category ignore list
......................................................................
Patch Set 2: (1 inline comment)
Shahar, see inline comment - maybe I will be more clear now.
....................................................
File backend/manager/modules/bll/pom.xml
Line 249: <version>${findbugs.version}</version>
Line 250: <configuration>
Line 251: <xmlOutput>true</xmlOutput>
Line 252: <!-- Optional directory to put findbugs xdoc
xml report -->
Line 253: <excludeFilterFile>
${basedir}/exclude-filters.xml,
${basedir}/../../../../exclude-filters-general.xml</excludeFilterFile>
No.
Local file in each project.
The general file -as today.
Always run the general profile - also at project level.
Eliminate in uncessary places the exclude-filters.xml file (don't understand
why we need the empty ones, you should be able to launch a profile from "root
pom" and in subprojects it does not have local exclude-filters.xml - it will
simply ignore , right?
Line 254:
<xmlOutputDirectory>target/site</xmlOutputDirectory>
Line 255: </configuration>
Line 256: </plugin>
Line 257: </plugins>
--
To view, visit http://gerrit.ovirt.org/15775
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfbc37df07eff4c212cc5210965cabd79a51df36
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
