Alon Bar-Lev has posted comments on this change. Change subject: add "action" to otopi environment ......................................................................
Patch Set 2: (2 inline comments) .................................................... File packaging/setup/plugins/ovirt-engine-remove/core/misc.py Line 49: self.environment.setdefault( Line 50: otopicons.CoreEnv.LOG_FILE_NAME_PREFIX, Line 51: osetupcons.FileLocations.OVIRT_OVIRT_REMOVE_LOG_PREFIX Line 52: ) Line 53: self.environment.setdefault( not setdefault... you want to enforce... Line 54: otopicons.CoreEnv.ACTION, Line 55: 'cleanup' Line 56: ) Line 57: Line 51: osetupcons.FileLocations.OVIRT_OVIRT_REMOVE_LOG_PREFIX Line 52: ) Line 53: self.environment.setdefault( Line 54: otopicons.CoreEnv.ACTION, Line 55: 'cleanup' I would have used constant here... so no typos. Line 56: ) Line 57: Line 58: @plugin.event( Line 59: stage=plugin.Stages.STAGE_INIT, -- To view, visit http://gerrit.ovirt.org/15915 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic34515956e7a374a8c255d6526f47603adda0bb5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
