Alon Bar-Lev has posted comments on this change. Change subject: add "action" to otopi environment ......................................................................
Patch Set 3: (1 inline comment) one last minor... sorry... .................................................... File packaging/setup/ovirt_engine_setup/constants.py Line 531: CONFIRM_UNINSTALL_GROUPS = 'OVESETUP_CORE/confirmUninstallGroups' Line 532: UPGRADE_SUPPORTED_VERSIONS = 'OVESETUP_CORE/upgradeSupportedVersions' Line 533: ACTION = 'OVESETUP_CORE/action' Line 534: ACTIONSETUP = 'setup' Line 535: ACTIONREMOVE = 'cleanup' Please move to Cons... While you at it... please add underscore... ACTION_ Thanks! Line 536: Line 537: @osetupattrs( Line 538: answerfile=True, Line 539: ) -- To view, visit http://gerrit.ovirt.org/15915 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic34515956e7a374a8c255d6526f47603adda0bb5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
