Laszlo Hornyak has posted comments on this change. Change subject: engine: add comment field to Host [3] ......................................................................
Patch Set 2: (2 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java Line 132: this.setId(vds_id); Line 133: this.setVdsName(vds_name); Line 134: this.setManagementIp(ip); Line 135: this.setHostName(host_name); Line 136: setComment(comment); Done Line 137: this.setPort(port); Line 138: this.setStatus(VDSStatus.forValue(status)); Line 139: this.setHardwareManufacturer(hwManufacturer); Line 140: this.setHardwareProductName(hwProductName); .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java Line 33: CreateEntity.class, UpdateEntity.class }) Line 34: private String name = ""; Line 35: Line 36: @EditableField Line 37: private String comment = ""; I think we should postpone the discussion over this for now. name also has a default value, however it will always be changed to something else and never will be that empty string. some cleanup would be nice indeed. Line 38: Line 39: @EditableField Line 40: @HostnameOrIp(message = "VALIDATION.VDS.POWER_MGMT.ADDRESS.HOSTNAME_OR_IP", groups = PowerManagementCheck.class) Line 41: @NotNull(groups = PowerManagementCheck.class) -- To view, visit http://gerrit.ovirt.org/15421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e1bec7c4a862813b19073344f48a0ec3c17458 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Noam Slomianko <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
