Laszlo Hornyak has posted comments on this change.
Change subject: engine: add comment field to Host [3]
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
Line 217: public static Host map(VDS entity, Host template) {
Line 218: Host model = template != null ? template : new Host();
Line 219: model.setId(entity.getId().toString());
Line 220: model.setName(entity.getName());
Line 221: model.setComment(entity.getComment());
Known issue here: mapping added to Vds => Host but no Host => Vds
Line 222: if (entity.getVdsGroupId() != null) {
Line 223: Cluster cluster = new Cluster();
Line 224: cluster.setId(entity.getVdsGroupId().toString());
Line 225: model.setCluster(cluster);
--
To view, visit http://gerrit.ovirt.org/15421
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06e1bec7c4a862813b19073344f48a0ec3c17458
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
