Alon Bar-Lev has posted comments on this change.

Change subject: add "action" to otopi environment
......................................................................


Patch Set 5:

> 'upgrade' will be used by a change Sandro is working on to add an otopi-based 
> 'setup-upgrade-2'

Usually, I in favor of adding stuff only when used... so if you rebase on top 
of that patch you add this with correct condition, if the other way around he 
adds this new constant.

Dead code tend to stay...

-- 
To view, visit http://gerrit.ovirt.org/15915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic34515956e7a374a8c255d6526f47603adda0bb5
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to