Alon Bar-Lev has posted comments on this change.
Change subject: Adding query for fetching ssh pubic key
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/OpenSSHUtils.java
Line 20: import org.apache.commons.logging.Log;
Line 21: import org.apache.commons.logging.LogFactory;
Line 22: import org.ovirt.engine.core.common.config.Config;
Line 23: import org.ovirt.engine.core.common.config.ConfigValues;
Line 24: import org.ovirt.engine.core.utils.EngineLocalConfig;
I tried to avoid using engine specific packages within purely generic and
project independent class.
OpenSSHUtils could have beeen taken as-is to another java project.... now it
cannot... This getEngineSSHPublicKey has nothing to do with OpenSSH...
Line 25:
Line 26: public class OpenSSHUtils {
Line 27: // The log:
Line 28: private static final Log log =
LogFactory.getLog(OpenSSHUtils.class);
--
To view, visit http://gerrit.ovirt.org/16019
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie508d6f9bdaa482f46a3cf1224b2fd84568299ba
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
