Alon Bar-Lev has posted comments on this change.
Change subject: Adding query for fetching ssh pubic key
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
Line 267: }},
Line 268: new Callable<Object>() { public Object call() throws
Exception {
Line 269: _parser.cliEnvironmentSet(
Line 270: NetEnv.SSH_KEY,
Line 271:
EngineEncryptionUtils.getEngineSSHPublicKey().replace("\n", "")
Why the extra indents?
Line 272: );
Line 273: return null;
Line 274: }},
Line 275: new Callable<Object>() { public Object call() throws
Exception {
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java
Line 15: import org.ovirt.engine.core.common.config.Config;
Line 16: import org.ovirt.engine.core.common.config.ConfigValues;
Line 17: import org.ovirt.engine.core.utils.EngineLocalConfig;
Line 18:
Line 19: public class EngineEncryptionUtils {
Hmm... not that I think it is not good... but why haven't you used
EncryptionUtils as-is? :)
Line 20:
Line 21: // The log:
Line 22: private static final Log log =
LogFactory.getLog(EngineEncryptionUtils.class);
Line 23:
--
To view, visit http://gerrit.ovirt.org/16019
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie508d6f9bdaa482f46a3cf1224b2fd84568299ba
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
