Alexander Wels has posted comments on this change.

Change subject: webadmin: branding: support If-Modified-Since instead of 
proprietary
......................................................................


Patch Set 3: I would prefer that you didn't submit this

The 'proprietary' ETag code generation is actually to match the ETags generated 
by the JBOSS file servlet. The JBOSS servlet uses the filesize and and last 
modified date to generate the ETag.

The last-modified header uses just the last modified date.

Neither technique will work in any kind of distributed environment which we 
obviously don't have. (Yet)

-- 
To view, visit http://gerrit.ovirt.org/16000
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e9f3c5ab6306300533de47b0e456a8fbaa2a218
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to