Alon Bar-Lev has posted comments on this change.

Change subject: webadmin: branding: support If-Modified-Since instead of 
proprietary
......................................................................


Patch Set 3:

Any approach taken should be available at ServletUtils and not to the branding 
servlet.

I can modify the leading patch[1] to use ETag as well.

However, as we discussed, ETag is not working correctly in Firefox (at least 
for me), this mean that if the branding package is modified it is not reflected 
to user.

Any other suggestion is welcomed, but we need this working... a change in disk 
should be reflected.

[1] http://gerrit.ovirt.org/#/c/15997/

-- 
To view, visit http://gerrit.ovirt.org/16000
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e9f3c5ab6306300533de47b0e456a8fbaa2a218
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to