Daniel Erez has posted comments on this change.
Change subject: webadmin: add the image block alignment scan
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java
Line 121: public String getValue(Disk object) {
Line 122: if (object.getLastAlignmentScan() != null) {
Line 123: String lastScanDate = DateTimeFormat
Line 124: .getFormat("yyyy-MM-dd,
HH:mm").format(object.getLastAlignmentScan()); //$NON-NLS-1$
Line 125:
getCell().setTooltip(messages.lastDiskAlignment(lastScanDate));
you can now remove the 'getCell()'...
Line 126: } else {
Line 127: getCell().setTooltip(null);
Line 128: }
Line 129: return object.getAlignment().toString();
Line 123: String lastScanDate = DateTimeFormat
Line 124: .getFormat("yyyy-MM-dd,
HH:mm").format(object.getLastAlignmentScan()); //$NON-NLS-1$
Line 125:
getCell().setTooltip(messages.lastDiskAlignment(lastScanDate));
Line 126: } else {
Line 127: getCell().setTooltip(null);
same
Line 128: }
Line 129: return object.getAlignment().toString();
Line 130: }
Line 131: };
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java
Line 70:
Line 71: @Override
Line 72: public TextCellWithEditableTooltip getCell() {
Line 73: TextCellWithEditableTooltip
textCellWithEditableTooltip = super.getCell();
Line 74:
textCellWithEditableTooltip.setTooltip(constants.quotaCalculationsMessage());
on second thought, just refactor it back to 'setTitle' (causes too many
unrelated changes ;)
Line 75: return textCellWithEditableTooltip;
Line 76: }
Line 77: },
Line 78: constants.usedStorageTotalQuotaStorage(), "400px");
//$NON-NLS-1$
--
To view, visit http://gerrit.ovirt.org/12417
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3a80a73e6f30f75806736a77a76247c61250b4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
