Daniel Erez has posted comments on this change.
Change subject: webadmin: add the image block alignment scan
......................................................................
Patch Set 4: Looks good to me, approved
(1 inline comment)
One last issue. Can be fixed on a separate patch, but please don't forget :)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
Line 674: }
Line 675:
Line 676: final VM vm = getEntity();
Line 677:
Line 678: AsyncDataProvider.getDataCenterById(new AsyncQuery(this, new
INewAsyncCallback() {
getDataCenterById query shouldn't be called on each disk selection. Instead,
call it only once - per VM selection (on setEntity method).
Can be fixed on a separate patch, but please don't forget :)
Line 679: @Override
Line 680: public void onSuccess(Object target, Object returnValue) {
Line 681: VmDiskListModel model = (VmDiskListModel) target;
Line 682: StoragePool dataCenter = (StoragePool) returnValue;
--
To view, visit http://gerrit.ovirt.org/12417
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3a80a73e6f30f75806736a77a76247c61250b4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
