Liron Ar has posted comments on this change.

Change subject: core: add the image block alignment scan
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java
Line 159:         } else {
Line 160:             throw new VdcBLLException(VdcBllErrors.ENGINE, "Unknown 
DiskStorageType: " +
Line 161:                 getDiskType().toString() + " Disk id: " + 
getDisk().getId().toString());
Line 162:         }
Line 163: 
(general comment for the command execution) - the comment was placed here by 
mistake.
Line 164:         Boolean isDiskAligned = (Boolean) runVdsCommand(
Line 165:                 VDSCommandType.GetDiskAlignment, 
parameters).getReturnValue();
Line 166: 
Line 167:         getDisk().setAlignment(isDiskAligned ? DiskAlignment.Aligned 
: DiskAlignment.Misaligned);


-- 
To view, visit http://gerrit.ovirt.org/11946
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4858b7bbfa453230fcafecfbc5358c715d5d825b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to