Daniel Erez has posted comments on this change.
Change subject: core: add the image block alignment scan
......................................................................
Patch Set 7: (2 inline comments)
rest-api support should be added later on as well
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java
Line 120: }
Line 121:
Line 122: if (!validate(new
StoragePoolValidator(getStoragePoolDao().get(getStoragePoolId())).isUp())) {
Line 123: return false;
Line 124: }
cluster level check should be added
Line 125:
Line 126: return true;
Line 127: }
Line 128:
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
Line 768:
Line 769: @DefaultStringValue("$action stop profiling")
Line 770: String VAR__ACTION__STOP_PROFILE();
Line 771:
Line 772: @DefaultStringValue("$action scan alignment")
should update all properties files as well (dal/webadmin/userportal)
Line 773: String VAR__ACTION__SCAN_ALIGNMENT();
Line 774:
Line 775: @DefaultStringValue("$action assign")
Line 776: String VAR__ACTION__ASSIGN();
--
To view, visit http://gerrit.ovirt.org/11946
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4858b7bbfa453230fcafecfbc5358c715d5d825b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
