Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Updated detecting network interfaces ......................................................................
Patch Set 1: (3 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2013-06-26 16:22:56 +0300 Line 4: Commit: Alex Lourie <[email protected]> Line 5: CommitDate: 2013-06-26 16:22:56 +0300 Line 6: Line 7: packaging: setup: Updated detecting network interfaces hi alex, every commit is "Updated" or "Change" you can just drop this. packaging: setup: support vlan interfaces Line 8: Line 9: This patch updates the regex used to detect network Line 10: interfaces. It is required to find extended interfaces, Line 11: such as ones with VLAN notation (eth3.2 or eth0.34@eth3). Line 5: CommitDate: 2013-06-26 16:22:56 +0300 Line 6: Line 7: packaging: setup: Updated detecting network interfaces Line 8: Line 9: This patch updates the regex used to detect network same for that... of course this is a patch :) You need to explain the problem and the solution. current implementation does that. new implementation does that. Line 10: interfaces. It is required to find extended interfaces, Line 11: such as ones with VLAN notation (eth3.2 or eth0.34@eth3). Line 12: Line 13: Change-Id: I1a53543671b02dcb9c66a2973ba40d238eb5220f .................................................... File packaging/fedora/setup/common_utils.py Line 603: def getConfiguredIps(): Line 604: interfaces = {} Line 605: addresses = {} Line 606: interfacere = re.compile( Line 607: '^\d+:\s+(?P<interface>\w+.*?):\s+<(?P<options>[^>]+).*' not good to use .*, you may catch chars you do not expect. Line 608: ) Line 609: addressre = re.compile( Line 610: '\s+inet (?P<address>\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}).+' Line 611: '\s+(?P<interface>\w+.*?)$' -- To view, visit http://gerrit.ovirt.org/16115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a53543671b02dcb9c66a2973ba40d238eb5220f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
