Alex Lourie has posted comments on this change.
Change subject: packaging: setup: Updated detecting network interfaces
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File packaging/fedora/setup/common_utils.py
Line 603: def getConfiguredIps():
Line 604: interfaces = {}
Line 605: addresses = {}
Line 606: interfacere = re.compile(
Line 607: '^\d+:\s+(?P<interface>\w+.*?):\s+<(?P<options>[^>]+).*'
basically *? means non-gready.
OK, the other alternative would be either specifying the specific set (such as
[a-zA-Z0-9.@-]) or specifying some like negation [^:]*
Line 608: )
Line 609: addressre = re.compile(
Line 610: '\s+inet (?P<address>\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}).+'
Line 611: '\s+(?P<interface>\w+.*?)$'
--
To view, visit http://gerrit.ovirt.org/16115
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a53543671b02dcb9c66a2973ba40d238eb5220f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
