Omer Frenkel has posted comments on this change.
Change subject: core: cleanup RemoveVmTemplateCommand#canDoAction
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
Line 124: }
Line 125: }
Line 126:
Line 127: // check no vms from this template on selected domains
Line 128: List<VM> vms =
getDbFacade().getVmDao().getAllWithTemplate(vmTemplateId);
cant you just make it getVmDAO() already?
Line 129: List<String> problematicVmNames = new ArrayList<String>();
Line 130: for (VM vm : vms) {
Line 131: if (getParameters().isRemoveTemplateFromDb()) {
Line 132: problematicVmNames.add(vm.getName());
--
To view, visit http://gerrit.ovirt.org/15877
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If669283fc057cff4eee46dfb15e004672d05fac1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
