Allon Mureinik has posted comments on this change.
Change subject: core: cleanup RemoveVmTemplateCommand#canDoAction
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
Line 96: // if some domains sent, check that the sent domains are
part of all domains
Line 97: List<String> problematicDomains = new ArrayList<String>();
Line 98: for (Guid domainId : storageDomainsList) {
Line 99: if (!allDomainsList.contains(domainId)) {
Line 100: StorageDomainStatic domain =
getDbFacade().getStorageDomainStaticDao().get(domainId);
just use getStorageDomainStaticDao()
Line 101: problematicDomains.add(domain == null ?
domainId.toString() : domain.getStorageName());
Line 102: }
Line 103: }
Line 104: if (!problematicDomains.isEmpty()) {
--
To view, visit http://gerrit.ovirt.org/15877
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If669283fc057cff4eee46dfb15e004672d05fac1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
