Alon Bar-Lev has posted comments on this change.
Change subject: Wrap validation of fingerprint in each connect using
EngineSSHClient
......................................................................
Patch Set 8: (5 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/EngineSSHClient.java
Line 20: */
Line 21: public class EngineSSHClient extends SSHClient {
Line 22:
Line 23: private static final Log log =
LogFactory.getLog(EngineSSHDialog.class);
Line 24: private VDS _vds;
are you sure this belongs to this patch?
Line 25:
Line 26: /**
Line 27: * Constructor.
Line 28: */
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/EngineSSHDialog.java
Line 62: }
Line 63:
Line 64: public void connect(VDS vds) throws Exception {
Line 65: try {
Line 66: if (_client != null) {
why do we need this here? the _client.connect() will issue whatever exception.
Line 67: throw new IOException("Already connected");
Line 68: }
Line 69: _client = _getSSHClient();
Line 70: if (getHardTimeout() != 0) {
Line 65: try {
Line 66: if (_client != null) {
Line 67: throw new IOException("Already connected");
Line 68: }
Line 69: _client = _getSSHClient();
this is not required here, the timeout initialization can be moved to the
_getSSHClient, no?
But anyway, it should be set by the base class, why do you need it here?
Line 70: if (getHardTimeout() != 0) {
Line 71: _client.setHardTimeout(getHardTimeout());
Line 72: }
Line 73: if (getSoftTimeout() != 0) {
Line 72: }
Line 73: if (getSoftTimeout() != 0) {
Line 74: _client.setSoftTimeout(getSoftTimeout());
Line 75: }
Line 76: ((EngineSSHClient)_client).setVds(vds);
this already been done at the _getSSHClient, no?
Line 77:
Line 78: log.debug("connecting");
Line 79: _client.connect();
Line 80: }
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java
Line 188: public void setSoftTimeout(long timeout) {
Line 189: _softTimeout = timeout;
Line 190: }
Line 191:
Line 192: public long getSoftTimeout() {
why is this required?
Line 193: return _softTimeout;
Line 194: }
Line 195:
Line 196: /**
--
To view, visit http://gerrit.ovirt.org/16126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01517a153406c8bafc672c20b0bf8686763a2f5
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
