Yaniv Bronhaim has posted comments on this change.

Change subject: Wrap validation of fingerprint in each connect using 
EngineSSHClient
......................................................................


Patch Set 8: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
Line 838:      */
Line 839:     public void execute(AuthenticationMethod auth) throws Exception {
Line 840:         InputStream in = null;
Line 841:         try {
Line 842:             _dialog.connect(_vds);
in finalize or close functions, the caller of execute should call to close when 
its ready. we do that from InstallVdsCommand.
Line 843:             _messages.post(
Line 844:                 InstallerMessages.Severity.INFO,
Line 845:                 String.format(
Line 846:                     "Connected to host %1$s with SSH key fingerprint: 
%2$s",


-- 
To view, visit http://gerrit.ovirt.org/16126
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01517a153406c8bafc672c20b0bf8686763a2f5
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to