Yaniv Bronhaim has posted comments on this change.
Change subject: Applying usage for public key authentication method
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 329: if (Config.<Boolean>
GetValue(ConfigValues.UseSecureConnectionWithServers)
Line 330: && !EngineEncryptionUtils.haveKey()) {
Line 331: returnValue =
failCanDoAction(VdcBllMessages.VDS_TRY_CREATE_SECURE_CERTIFICATE_NOT_FOUND);
Line 332: } else if (!getParameters().getAddPending()
Line 333: && (getParameters().getAuthMethod() ==
AuthenticationMethod.Password)
this verification checks if the user chose password authenitication and didn't
enter a valid password (if we use public key, this field can remain empty).
The getAuthMethod can be either 0 or 1 , we don't need to verify it.
Line 334: &&
StringUtils.isEmpty(getParameters().getPassword())) {
Line 335: // We block vds installations if it's not a
RHEV-H and password is empty
Line 336: // Note that this may override local host SSH
policy. See BZ#688718.
Line 337: returnValue =
failCanDoAction(VdcBllMessages.VDS_CANNOT_INSTALL_EMPTY_PASSWORD);
--
To view, visit http://gerrit.ovirt.org/16270
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54591b2b6cc99114f53124ee5a74c2b35f950304
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
