Alon Bar-Lev has posted comments on this change. Change subject: Applying usage for public key authentication method ......................................................................
Patch Set 6: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java Line 16: Line 17: import javax.naming.TimeLimitExceededException; Line 18: Line 19: import org.apache.commons.lang.StringUtils; Line 20: import org.ovirt.engine.core.bll.utils.EngineSSHDialog; are you sure this is required in this patch? Line 21: import org.ovirt.engine.core.common.businessentities.VDS; Line 22: import org.ovirt.engine.core.common.businessentities.VDSGroup; Line 23: import org.ovirt.engine.core.common.businessentities.VDSType; Line 24: import org.ovirt.engine.core.common.config.Config; Line 849: _vds.getHostName(), Line 850: _dialog.getHostFingerprint() Line 851: ) Line 852: ); Line 853: are you sure this is required? Line 854: _dialog.authenticate(); Line 855: Line 856: String command = Config.<String> GetValue(ConfigValues.BootstrapCommand); Line 857: -- To view, visit http://gerrit.ovirt.org/16270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54591b2b6cc99114f53124ee5a74c2b35f950304 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
