Martin Peřina has uploaded a new change for review. Change subject: core: VdsNotRespondingTreatmentCommand.executeCommand cleanup ......................................................................
core: VdsNotRespondingTreatmentCommand.executeCommand cleanup Adds result of command execution to the return value. Change-Id: Ie39b2c0e415e5fd8359a85bc76d74aecd9b428af Signed-off-by: Martin Perina <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/37/16337/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java index 462453e..bc3ccf3 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java @@ -51,17 +51,20 @@ if (getVds() == null) { setCommandShouldBeLogged(false); log.infoFormat("Host {0}({1}) not fenced since it doesn't exist anymore.", getVdsName(), getVdsId()); + getReturnValue().setSucceeded(false); return; } validator = new VdsValidator(getVds()); - if (validator.shouldVdsBeFenced()) { + boolean shouldBeFenced = validator.shouldVdsBeFenced(); + if (shouldBeFenced) { super.executeCommand(); } else { setCommandShouldBeLogged(false); log.infoFormat("Host {0}({1}) not fenced since it's status is ok, or it doesn't exist anymore.", getVdsName(), getVdsId()); } + getReturnValue().setSucceeded(shouldBeFenced); } @Override -- To view, visit http://gerrit.ovirt.org/16337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie39b2c0e415e5fd8359a85bc76d74aecd9b428af Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
