Federico Simoncelli has posted comments on this change.
Change subject: [wip] frontend: add glance storage domain support
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/DiskSizeRenderer.java
Line 20: }
Line 21:
Line 22: @Override
Line 23: public String render(T size) {
Line 24: if (size == null || size.longValue() == 0) {
Glance doesn't report stats about free space, etc. "< 1 GB" looks confusing and
wrong, "NA" is preferable when the size is 0.
Line 25: return "NA"; //$NON-NLS-1$
Line 26: }
Line 27:
Line 28: long sizeInGB = -1;
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
Line 1073: boolean isBackupStorage = storage.getStorageDomainType()
== StorageDomainType.ImportExport;
Line 1074: boolean isDataStorage =
Line 1075: storage.getStorageDomainType() ==
StorageDomainType.Data
Line 1076: || storage.getStorageDomainType() ==
StorageDomainType.Master;
Line 1077: boolean isImageStorage =
Glance doesn't belong to any Data Center and doesn't report stats about
available size, etc. The "General" and "Data Center" tabs are useless.
Line 1078: storage.getStorageDomainType() ==
StorageDomainType.Image ||
Line 1079: storage.getStorageDomainType() ==
StorageDomainType.ISO;
Line 1080: boolean isDataCenterAvailable = storage.getStorageType()
!= StorageType.GLANCE;
Line 1081: boolean isGeneralAvailable = storage.getStorageType() !=
StorageType.GLANCE;
--
To view, visit http://gerrit.ovirt.org/15898
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07274bbc14e52471242935fcf99b510469ec4abe
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
