Allon Mureinik has posted comments on this change.
Change subject: core: check no running VMs use storage conn
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
+1 on all the implemented changes, giving -1 so this is not merged by mistake
until locks are implemented.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
Line 358:
VdcBllMessages.ACTION_TYPE_FAILED_OBJECT_LOCKED));
Line 359: }
Line 360: else {
Line 361: // for block domains, locking the target details
Line 362: locks.put(getConnection().getconnection() + ";" +
getConnection().getiqn() + ";" + getConnection().getport() + ";" +
getConnection().getuser_name(),
consider extracting ";" to a constant
Line 363:
LockMessagesMatchUtil.makeLockingPair(LockingGroup.STORAGE_CONNECTION,
Line 364: VdcBllMessages.ACTION_TYPE_FAILED_OBJECT_LOCKED));
Line 365: }
Line 366:
--
To view, visit http://gerrit.ovirt.org/16203
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11fe22760952e1319654647eed661a7814675f64
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
