Allon Mureinik has posted comments on this change.
Change subject: core: check no running VMs use storage conn
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
Line 124: return domainNames.toString();
Line 125: }
Line 126:
Line 127: protected List<LUNs> getLuns() {
Line 128: if(luns.isEmpty()) {
what about formatting?
Line 129: luns =
getLunDao().getAllForStorageServerConnection(getConnection().getid());
Line 130: }
Line 131: return luns;
Line 132: }
Line 369:
LockMessagesMatchUtil.makeLockingPair(LockingGroup.STORAGE_CONNECTION,
Line 370: VdcBllMessages.ACTION_TYPE_FAILED_OBJECT_LOCKED));
Line 371:
Line 372: //lock lun disks and domains, not VMs , no need to load
from db.
Line 373: if(getLuns()!=null) {
formatting
Line 374: for(LUNs lun : getLuns()) {
Line 375: Guid diskId = lun.getDiskId();
Line 376: Guid storageDomainId = lun.getStorageDomainId();
Line 377: if(diskId != null) {
Line 370: VdcBllMessages.ACTION_TYPE_FAILED_OBJECT_LOCKED));
Line 371:
Line 372: //lock lun disks and domains, not VMs , no need to load
from db.
Line 373: if(getLuns()!=null) {
Line 374: for(LUNs lun : getLuns()) {
formatting
Line 375: Guid diskId = lun.getDiskId();
Line 376: Guid storageDomainId = lun.getStorageDomainId();
Line 377: if(diskId != null) {
Line 378:
locks.put(diskId.toString(),LockMessagesMatchUtil.makeLockingPair(LockingGroup.DISK,
--
To view, visit http://gerrit.ovirt.org/16203
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11fe22760952e1319654647eed661a7814675f64
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
