Vojtech Szocs has posted comments on this change. Change subject: webadmin: Added infrastructure for linking to System Tree items ......................................................................
Patch Set 9: Looks good to me, but someone else must approve Looks good but I have some minor questions: * just to be on safe side, is it safe to assume SystemTreeItemModel's (entity) ID will always be != null? * maybe I'm missing something, but I can't find any code responsible for updating SystemTreeItemModel.treeItemById map (this map will be empty, so SystemTreeItemModel.getItemById will return null) * I agree that BOUND_TO_SELECTION is buggy when trying to reflect current selection in tree view so I see why you used ENABLED, but maybe we can add some extra logic to simulate original BOUND_TO_SELECTION behavior? Workarounds for simulating original BOUND_TO_SELECTION behavior: * http://code.google.com/p/google-web-toolkit/issues/detail?id=6310#c4 -> use ENABLED permanently, add keydown handler to handle UP/DOWN keys, update selection model accordingly * add selection change handler to selection model, inside this handler update "keyboard selected row" to reflect selection in tree view, i.e. use CellTree.keyboardSelect(node,true) where "node" is CellTreeNodeView representing currently selected item -- To view, visit http://gerrit.ovirt.org/15522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I799aa4dfcd8ad7264057810e408cd1c64ea711e8 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
