Lior Vernia has posted comments on this change. Change subject: webadmin: Added infrastructure for linking to System Tree items ......................................................................
Patch Set 9: * As long as the SystemTreeItemModel represents an actual entity (i.e. isn't a grouping node like "DataCenters"), as far as I know its Entity's GUID is guaranteed to not be null. * You are definitely right, in this patch there's not yet any code to populate the map. In the following two patches though I've inserted Provider and Network items there so they can be fetched, I imagine other entities will be pushed there as needed. Or do you think it'd be better to just put all the entities there in the first place? * As for the suggestions to emulate the BOUND_TO_SELECTION keyboard selection policy, your second suggestion is what I originally preferred to do, but the keyboardSelect() method isn't accessible (it has package access). So I guess it would have to be the up/down key handlers, or derez's scheduler magic. I'll probably do the key handlers because the code would be more comprehensible. -- To view, visit http://gerrit.ovirt.org/15522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I799aa4dfcd8ad7264057810e408cd1c64ea711e8 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
