Frank Kobzik has uploaded a new change for review. Change subject: core: fix NPEx when adding new vm pool ......................................................................
core: fix NPEx when adding new vm pool This patch adds handling of null value of the soundcard attribute when creating a new VM pool. Without it the creation of the VM pool was throwing NPEx when the attribute wasn't specified (tried with restapi). Change-Id: I51262b8ceec47ab4e36b0180ec8d3fd9af6033b3 Signed-off-by: Frantisek Kobzik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/39/16539/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java index 5a7dead..b71fe5d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java @@ -113,7 +113,7 @@ diskInfoDestinationMap); addVmAndAttachToPoolParams.setSessionId(getParameters().getSessionId()); addVmAndAttachToPoolParams.setParentCommand(VdcActionType.AddVmPoolWithVms); - addVmAndAttachToPoolParams.setSoundDeviceEnabled(getParameters().isSoundDeviceEnabled()); + addVmAndAttachToPoolParams.setSoundDeviceEnabled(Boolean.TRUE.equals(getParameters().isSoundDeviceEnabled())); addVmAndAttachToPoolParams.setConsoleEnabled(getParameters().isConsoleEnabled()); VdcReturnValueBase returnValue = Backend.getInstance().runInternalAction(VdcActionType.AddVmAndAttachToPool, -- To view, visit http://gerrit.ovirt.org/16539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I51262b8ceec47ab4e36b0180ec8d3fd9af6033b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
