Omer Frenkel has posted comments on this change. Change subject: core: fix NPEx when adding new vm pool ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java Line 112: new AddVmAndAttachToPoolParameters(currVm, poolId, currentVmName, Line 113: diskInfoDestinationMap); Line 114: addVmAndAttachToPoolParams.setSessionId(getParameters().getSessionId()); Line 115: addVmAndAttachToPoolParams.setParentCommand(VdcActionType.AddVmPoolWithVms); Line 116: addVmAndAttachToPoolParams.setSoundDeviceEnabled(Boolean.TRUE.equals(getParameters().isSoundDeviceEnabled())); for rest the "old" behavior should be preserved, means handling the same as in AddVmCommand (if null then by vmType) Line 117: addVmAndAttachToPoolParams.setConsoleEnabled(getParameters().isConsoleEnabled()); Line 118: VdcReturnValueBase returnValue = Line 119: Backend.getInstance().runInternalAction(VdcActionType.AddVmAndAttachToPool, Line 120: addVmAndAttachToPoolParams, -- To view, visit http://gerrit.ovirt.org/16539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51262b8ceec47ab4e36b0180ec8d3fd9af6033b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
