Sahina Bose has posted comments on this change.
Change subject: restapi: REST apis for gluster SWIFT maintenance
......................................................................
Patch Set 2: (7 inline comments)
My comments inline.
You'll also need to add rsdl_metadata.yaml and tests to BackendHostResourceTest
for the glusterservice{action} methods
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 1282: <xs:element ref="hooks" minOccurs="0"/>
Line 1283: <xs:element name="libvirt_version" type="Version"
minOccurs="0" maxOccurs="1"/>
Line 1284: <!-- Optionally specify the display address of this host
explicitly -->
Line 1285: <xs:element ref="display" minOccurs="0"/>
Line 1286: <xs:element ref="glusterservices" minOccurs="0"/>
This should be an element of Host type.
Line 1287: </xs:sequence>
Line 1288: </xs:extension>
Line 1289: </xs:complexContent>
Line 1290: </xs:complexType>
Line 1684: <xs:annotation>
Line 1685: <xs:appinfo>
Line 1686: <jaxb:class name="GlusterService"/>
Line 1687: </xs:appinfo>
Line 1688: </xs:annotation>
you may want to take off the tabs
Line 1689: <xs:complexContent>
Line 1690: <xs:extension base="BaseResource">
Line 1691: <xs:sequence>
Line 1692: <xs:element ref="host" minOccurs="0"/>
Line 1689: <xs:complexContent>
Line 1690: <xs:extension base="BaseResource">
Line 1691: <xs:sequence>
Line 1692: <xs:element ref="host" minOccurs="0"/>
Line 1693: <xs:element name="status" type="xs:string" minOccurs="0"/>
It would be good to add the gluster_service_type here
Line 1694: </xs:sequence>
Line 1695: </xs:extension>
Line 1696: </xs:complexContent>
Line 1697: </xs:complexType>
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
Line 208: }
Line 209:
Line 210: @Override
Line 211: public Response glusterServiceStart(Action action) {
Line 212: return doAction(VdcActionType.ManageGlusterService, new
GlusterServiceParameters(null,
Need to validate that action has GlusterServiceType parameter
Line 213: guid,
Line 214: ServiceType.valueOf(action.getGlusterServiceType()),
Line 215: "start"), action);
Line 216: }
Line 219: public Response glusterServiceStop(Action action) {
Line 220: return doAction(VdcActionType.ManageGlusterService, new
GlusterServiceParameters(null,
Line 221: guid,
Line 222: ServiceType.valueOf(action.getGlusterServiceType()),
Line 223: "stop"), action);
same as above
Line 224: }
Line 225:
Line 226: @Override
Line 227: public Response glusterServiceReStart(Action action) {
Line 227: public Response glusterServiceReStart(Action action) {
Line 228: return doAction(VdcActionType.ManageGlusterService, new
GlusterServiceParameters(null,
Line 229: guid,
Line 230: ServiceType.valueOf(action.getGlusterServiceType()),
Line 231: "restart"), action);
same as above
Line 232: }
Line 233:
Line 234: protected LogicalUnit map(StorageServerConnections cnx) {
Line 235: return getMapper(StorageServerConnections.class,
LogicalUnit.class).map(cnx, null);
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java
Line 32:
Line 33: public class BackendHostsResource extends
AbstractBackendCollectionResource<Host, VDS> implements
Line 34: HostsResource {
Line 35:
Line 36: static final String[] SUB_COLLECTIONS = { "storage", "nics",
"tags", "permissions", "statistics", "hooks", "glusterservices" };
glusterservices should not list in virt only mode
Line 37: static final String GLUSTERONLY_MODE_COLLECTIONS_TO_HIDE =
"storage";
Line 38:
Line 39: public BackendHostsResource() {
Line 40: super(Host.class, VDS.class, SUB_COLLECTIONS);
--
To view, visit http://gerrit.ovirt.org/16691
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I87cb354e10fed21cbd18b874595b726d3ac018a6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
