Shubhendu Tripathi has posted comments on this change.

Change subject: restapi: REST apis for gluster SWIFT maintenance
......................................................................


Patch Set 6: (2 inline comments)

....................................................
Commit Message
Line 9: This patch adds API support for managing gluster services.
Line 10:  - api/hosts/{id}/glusterservices
Line 11:    lists all gluster services in the host
Line 12:  - api/hosts/{id}/glusterservices/{glusterservice:id}
Line 13:    shows details of individual gluster service on the said host
Will rename it to "services" and service type is already being displayed as 
part of individual service listing.
Line 14: 
Line 15: Actions supported:
Line 16:  - api/hosts/{id}/glusterservicestart
Line 17:    starts all the gluster services in the said host for a given type


Line 17:    starts all the gluster services in the said host for a given type
Line 18:  - api/hosts/{id}/glusterservicestop
Line 19:    stops all the gluster services in the said host for a given type
Line 20:  - api/hosts/{id}/glusterservicerestart
Line 21:    re-starts all the gluster services in the said host for a given type
start|stop|restart at api/hosts/{id} level would look like start|stop|restart 
of host itself whereas we are trying to start|stop|restart the services here.
So I feel better these actions could be called as 
startservice|stopservice|restartservice.
These commands would take service type as an argument and so would 
start/stop/restart services on a given host and of a specific type.

Kindly provide your comments for the same.
Line 22: 
Line 23: Change-Id: I87cb354e10fed21cbd18b874595b726d3ac018a6


-- 
To view, visit http://gerrit.ovirt.org/16691
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87cb354e10fed21cbd18b874595b726d3ac018a6
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to