ofri masad has posted comments on this change.
Change subject: webadmin: Add Network QoS to webadmin
......................................................................
Patch Set 3: (13 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkQoSListModel.java
Line 137:
Line 138: public void edit() {
Line 139: final NetworkQoS networkQoS = (NetworkQoS) getSelectedItem();
Line 140:
Line 141: if (getWindow() != null)
Done
Line 142: {
Line 143: return;
Line 144: }
Line 145:
Line 163: updateActionAvailability();
Line 164: }
Line 165:
Line 166: private void updateActionAvailability() {
Line 167: List tempVar = getSelectedItems();
Done
Line 168: ArrayList selectedItems = (ArrayList) ((tempVar != null) ?
tempVar : new ArrayList());
Line 169:
Line 170: getEditCommand().setIsExecutionAllowed(selectedItems.size()
== 1);
Line 171: getRemoveCommand().setIsExecutionAllowed(selectedItems.size()
> 0);
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/RemoveNetworkQoSModel.java
Line 43: parameters.add(parameter);
Line 44: }
Line 45: Frontend.RunMultipleAction(VdcActionType.RemoveNetworkQoS,
parameters);
Line 46:
Line 47: sourceListModel.setConfirmWindow(null);
Done
Line 48: }
Line 49:
Line 50: private void cancel() {
Line 51: sourceListModel.setConfirmWindow(null);
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java
Line 303: // {
Line 304: // ConfigureLocalStorageModel model =
(ConfigureLocalStorageModel) getModel().getWindow();
Line 305: // if (!model.getDontCreateDataCenter())
Line 306: // {
Line 307: // DataCenterModel m = model.getDataCenters();
Done
Line 308: // String name = (String) m.getName().getEntity();
Line 309: // // Try to find existing data center with the specified name.
Line 310: // storage_pool dataCenter =
DataProvider.GetDataCenterByName(name);
Line 311: // if (dataCenter != null)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java
Line 624: // ArrayList<String> listNames = new ArrayList<String>();
Line 625: // //In case we found a suitable candidate for re-use:
Line 626: // if(candidate != null)
Line 627: // {
Line 628: // getDataCenters().setDataCenterId(candidate.getId());
Done
Line 629: // getDataCenters().getName().setEntity(candidate.getName());
Line 630: //
getDataCenters().getDescription().setEntity(candidate.getdescription());
Line 631: // Version compVersion = candidate.getcompatibility_version();
Line 632: // getDataCenters().getVersion().setSelectedItem(compVersion);
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 235: VAR__TYPE__USER_FROM_VM=$type User to VM
Line 236: VAR__TYPE__USER=$type User
Line 237: VAR__TYPE__PERMISSION=$type Permission
Line 238: VAR__TYPE__HOST_CAPABILITIES=$type Host capabilities
Line 239: VAR__TYPE__NETWORK_QOS=$type Network QoS
Done
Line 240: VAR__ACTION__RUN=$action run
Line 241: VAR__ACTION__REMOVE=$action remove
Line 242: VAR__ACTION__ADD=$action add
Line 243: VAR__ACTION__CREATE=$action create
Line 827: ACTION_TYPE_FAILED_EXTERNAL_EVENT_ILLEGAL_ORIGIN=Cannot ${action}
${type}. Illegal Origin for External Event : oVirt
Line 828: ACTION_TYPE_FAILED_EXTERNAL_EVENT_NOT_FOUND=Cannot ${action}
${type}.External Event does not exist.
Line 829: ACTION_TYPE_FAILED_EXTERNAL_EVENT_ILLRGAL_OPERATION=Cannot ${action}
${type}.Only Alerts can be removed.
Line 830: FAILED_TO_RUN_LDAP_QUERY=Failed to run LDAP query, please contact
your system administrator.
Line 831:
Done
Line 832: ACTION_TYPE_FAILED_NETWORK_QOS_MISSING_VALUES=Cannot ${action}
${type}. All three values are needed in order to define QoS on each network
directions.
Line 833: ACTION_TYPE_FAILED_NETWORK_QOS_NEGATIVE_VALUES=Cannot ${action}
${type}. Negative values are not allowed.
Line 834: ACTION_TYPE_FAILED_NETWORK_QOS_OUT_OF_RANGE_VALUES=Cannot ${action}
${type}. Values are out of range.
Line 835: ACTION_TYPE_FAILED_NETWORK_QOS_NAME_EXIST=Cannot ${action} ${type}.
Duplicate QoS name in Data Center.
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 2879:
Line 2880: @DefaultStringValue("Enter host fingerprint or <a>fetch</a>
manually from host")
Line 2881: String fetchingHostFingerprint();
Line 2882:
Line 2883: @DefaultStringValue("Name")
Done
Line 2884: String NetworkQoSName();
Line 2885:
Line 2886: @DefaultStringValue("In Average")
Line 2887: String NetworkQoSInboundAverage();
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DataCenterModule.java
Line 222: return new SearchableDetailTabModelProvider<NetworkQoS,
DataCenterListModel, DataCenterNetworkQoSListModel>(ginjector,
Line 223: DataCenterListModel.class,
Line 224: DataCenterNetworkQoSListModel.class) {
Line 225: @Override
Line 226: public AbstractModelBoundPopupPresenterWidget<? extends
Model, ?> getModelPopup(DataCenterNetworkQoSListModel source,
Done
Line 227:
UICommand lastExecutedCommand,
Line 228:
Model windowModel) {
Line 229: if
(lastExecutedCommand.equals(getModel().getNewCommand())
Line 230: ||
lastExecutedCommand.equals(getModel().getEditCommand())) {
Line 234: }
Line 235: }
Line 236:
Line 237: @Override
Line 238: public AbstractModelBoundPopupPresenterWidget<? extends
ConfirmationModel, ?> getConfirmModelPopup(DataCenterNetworkQoSListModel source,
Done
Line 239:
UICommand lastExecutedCommand) {
Line 240: if
(lastExecutedCommand.equals(getModel().getRemoveCommand())) {
Line 241: return removeConfirmPopupProvider.get();
Line 242: } else {
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/datacenter/SubTabDataCenterNetworkQoSPresenter.java
Line 40:
ginjector.getSubTabDataCenterNetworkQoSModelProvider());
Line 41: }
Line 42:
Line 43: @Inject
Line 44: public SubTabDataCenterNetworkQoSPresenter(EventBus eventBus,
ViewDef view, ProxyDef proxy,
Done
Line 45: PlaceManager
placeManager,
Line 46:
SearchableDetailModelProvider<NetworkQoS, DataCenterListModel,
Line 47:
DataCenterNetworkQoSListModel> modelProvider) {
Line 48: super(eventBus, view, proxy, placeManager, modelProvider);
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterNetworkQoSView.java
Line 24: ViewIdHandler idHandler = GWT.create(ViewIdHandler.class);
Line 25: }
Line 26:
Line 27: @Inject
Line 28: public
SubTabDataCenterNetworkQoSView(SearchableDetailModelProvider<NetworkQoS,
DataCenterListModel, DataCenterNetworkQoSListModel> modelProvider,
ApplicationConstants constants) {
Done
Line 29: super(modelProvider);
Line 30: ViewIdHandler.idHandler.generateAndSetIds(this);
Line 31: initTable(constants);
Line 32: initWidget(getTable());
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 881: ACTION_TYPE_FAILED_SERVER_SERVICE_NOT_FOUND=Cannot ${action} ${type}.
Service not found.
Line 882: ACTION_TYPE_FAILED_SERVICE_ALREADY_RUNNING=Cannot ${action} ${type}.
Service ${service} is already running on server ${server}.
Line 883: ACTION_TYEPE_FAILED_SERVICE_ALREADY_STOPPED=Cannot ${action} ${type}.
Service ${service} already stopped on Server ${server}.
Line 884: CLUSTER_ALL_SERVERS_NOT_UP=One or more servers in the cluster is down
Line 885: ACTION_TYPE_FAILED_NETWORK_QOS_MISSING_VALUES=Cannot ${action}
${type}. All three values are needed in order to define QoS on each network
directions.
Not sure what you meant...
if you are referring to
backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties then
it was changed in previous patch.
Line 886: ACTION_TYPE_FAILED_NETWORK_QOS_NEGATIVE_VALUES=Cannot ${action}
${type}. Negative values are not allowed.
Line 887: ACTION_TYPE_FAILED_NETWORK_QOS_OUT_OF_RANGE_VALUES=Cannot ${action}
${type}. Values are out of range.
Line 888: ACTION_TYPE_FAILED_NETWORK_QOS_NAME_EXIST=Cannot ${action} ${type}.
Duplicate QoS name in Data Center.
Line 889: ACTION_TYPE_FAILED_NETWORK_QOS_MISSING_DATA=Cannot ${action} ${type}.
Invalid QoS.
--
To view, visit http://gerrit.ovirt.org/16453
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf3e26c09b41306452302e36710658393b7b55b8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
