Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Add Network QoS to webadmin
......................................................................
Patch Set 10: (3 inline comments)
....................................................
Commit Message
Line 5: CommitDate: 2013-07-15 11:24:48 +0300
Line 6:
Line 7: webadmin: Add Network QoS to webadmin
Line 8:
Line 9: Add UI of Network QoS to webadmin
please describe the changes a bit or at least add a reference to the feature
page
Line 10:
Line 11: Change-Id: Iaf3e26c09b41306452302e36710658393b7b55b8
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
Line 173: }
Line 174:
Line 175: DataCenterQuotaListModel quotaListModel;
Line 176:
Line 177: DataCenterNetworkQoSListModel networkQoSListModel;
why do you need this field?
Line 178:
Line 179: public DataCenterListModel()
Line 180: {
Line 181:
setTitle(ConstantsManager.getInstance().getConstants().dataCentersTitle());
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkQoSListModel.java
Line 35: }
Line 36:
Line 37: @Override
Line 38: public StoragePool getEntity() {
Line 39: return (StoragePool) ((super.getEntity() instanceof
StoragePool) ? super.getEntity() : null);
do you need this check? Since the setEntity already takes only StoragePool...
Line 40: }
Line 41:
Line 42: public void setEntity(StoragePool value) {
Line 43: super.setEntity(value);
--
To view, visit http://gerrit.ovirt.org/16453
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf3e26c09b41306452302e36710658393b7b55b8
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
