Itamar Heim has posted comments on this change.
Change subject: core: Architecture related validation and queries
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmTemplatesByStoragePoolAndClusterIdParameters.java
Line 1: package org.ovirt.engine.core.common.queries;
Line 2:
Line 3: import org.ovirt.engine.core.compat.Guid;
Line 4:
Line 5: public class GetVmTemplatesByStoragePoolAndClusterIdParameters extends
VdcQueryParametersBase {
why is this needed? pay attention templates are DC level - you can't assume the
default cluster of the template implies its cpu arch necessarily. specifically,
that won't hold with instance types (just images, no defaults other than OS
like templates have) , which don't have a default cluster at all.
similarly, how would import template (which may not have a default cluster at
all), or import of an image from glance will behave wrt arch)?
Line 6:
Line 7: private static final long serialVersionUID = 1785071147583794793L;
Line 8:
Line 9:
....................................................
Commit Message
Line 17: before attaching disk
Line 18: * Check compatibility of cluster architecture when editing host and VMs
Line 19: * Do not allow clusters to accept hosts with different architectures
Line 20: * When migrating VMs the destination host must have the same
Line 21: architecture of the cluster
destination host is inside same cluster today, so not an issue. but validation
could be relevant in the future when allowing live migration without shared
storage
Line 22: * Do not allow clusters to change their architecture (processor name of
Line 23: different architecture) while there are VMs and hosts attached
Line 24: * Do not allow VMs to change their clusters if the destination cluster
Line 25: has a different architecture
--
To view, visit http://gerrit.ovirt.org/16701
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I461c4d11d5f5423648b1a6b5881d0525d5d8c49c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
