Itamar Heim has posted comments on this change.
Change subject: core: Architecture related validation and queries
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmTemplatesByStoragePoolAndClusterIdParameters.java
Line 1: package org.ovirt.engine.core.common.queries;
Line 2:
Line 3: import org.ovirt.engine.core.compat.Guid;
Line 4:
Line 5: public class GetVmTemplatesByStoragePoolAndClusterIdParameters extends
VdcQueryParametersBase {
it sounds like you don't need to persist the arch, since the OS is unique per
arch (even if display name to user is the same).
(a) however, since OVF OSType[1] doesn't have this distinction, it means that
at least during import, we will need the user to specify the arch, if the
selected OS has more than a single arch?
(b) that will be good enough for importing from external system/images like
glance, but for export/import between oVirt systems, I would like the OVF to
include the arch info, but haven't found a good place for that yet - I'll send
an email to the list in hopes someone has a good idea around this.
for now, i guess (a) will have to do.
[1] http://schemas.dmtf.org/wbem/cim-html/2.31.0/CIM_OperatingSystem.html
Line 6:
Line 7: private static final long serialVersionUID = 1785071147583794793L;
Line 8:
Line 9:
--
To view, visit http://gerrit.ovirt.org/16701
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I461c4d11d5f5423648b1a6b5881d0525d5d8c49c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
